Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom boxes for directions #185

Merged
merged 2 commits into from May 25, 2019
Merged

Custom boxes for directions #185

merged 2 commits into from May 25, 2019

Conversation

intere
Copy link
Collaborator

@intere intere commented May 18, 2019 •
edited

Background

  • Provide your own custom boxes as a template for directions.
    • Currently you just get a navy blue colored box that's 1m x 0.2m x distance between points with a 0 chamfer radius
  • Added an optional block type that you can pass to the PolylineNode API that lets you specify how a SCNBox for directions is created.
  • Removed the lighting with the PolylineNode (it was [ironically] interfering with the lighting)
  • Added some (horrible, but obviously visible) images to use as diffuse materials for an example (see screenshots)

Breaking Changes

There should be no breaking changes

Meta

  • Tied to Version Release(s): next (post 1.1.0)

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

crazy_box

blue_box

@intere intere added enhancement under construction not ready to be merged yet, still in progress labels May 18, 2019
@intere intere self-assigned this May 18, 2019
@intere intere removed the under construction not ready to be merged yet, still in progress label May 25, 2019
@intere intere marked this pull request as ready for review May 25, 2019 17:22
aaronbrethorst
aaronbrethorst approved these changes May 25, 2019
View reviewed changes
Copy link
Collaborator

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! nice work!

@aaronbrethorst aaronbrethorst merged commit f05806c into AndrewHartAR:develop May 25, 2019
@intere intere deleted the feature/CustomBoxesForDirections branch May 25, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees

@intere intere

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@intere @aaronbrethorst